linux-kernel - Re: [PATCH 14/78] staging: media: imx7-mipi-csis: use pm_runtime_resume_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Apr 2021 11:11:13 +0100
From:   "Rui Miguel Silva" <rmfrfs@...il.com>
To:     "Mauro Carvalho Chehab" <mchehab+huawei@...nel.org>
Cc:     <linuxarm@...wei.com>, <mauro.chehab@...wei.com>,
        "Fabio Estevam" <festevam@...il.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        "NXP Linux Team" <linux-imx@....com>,
        "Pengutronix Kernel Team" <kernel@...gutronix.de>,
        "Philipp Zabel" <p.zabel@...gutronix.de>,
        "Sascha Hauer" <s.hauer@...gutronix.de>,
        "Shawn Guo" <shawnguo@...nel.org>,
        "Steve Longerbeam" <slongerbeam@...il.com>,
        <devel@...verdev.osuosl.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-media@...r.kernel.org>
Subject: Re: [PATCH 14/78] staging: media: imx7-mipi-csis: use
 pm_runtime_resume_and_get()

Hi Mauro,
On Sat Apr 24, 2021 at 7:44 AM WEST, Mauro Carvalho Chehab wrote:
> Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
> added pm_runtime_resume_and_get() in order to automatically handle
> dev->power.usage_count decrement on errors.
>
> Use the new API, in order to cleanup the error check logic.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>

Thanks, looks good.

Acked-by: Rui Miguel Silva <rmfrfs@...il.com>

------
Cheers,
	 Rui
> ---
>  drivers/staging/media/imx/imx7-mipi-csis.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c
> index 025fdc488bd6..1dc680d94a46 100644
> --- a/drivers/staging/media/imx/imx7-mipi-csis.c
> +++ b/drivers/staging/media/imx/imx7-mipi-csis.c
> @@ -695,11 +695,10 @@ static int mipi_csis_s_stream(struct v4l2_subdev *mipi_sd, int enable)
>  
>  		mipi_csis_clear_counters(state);
>  
> -		ret = pm_runtime_get_sync(&state->pdev->dev);
> -		if (ret < 0) {
> -			pm_runtime_put_noidle(&state->pdev->dev);
> +		ret = pm_runtime_resume_and_get(&state->pdev->dev);
> +		if (ret < 0)
>  			return ret;
> -		}
> +
>  		ret = v4l2_subdev_call(state->src_sd, core, s_power, 1);
>  		if (ret < 0 && ret != -ENOIOCTLCMD)
>  			goto done;
> -- 
> 2.30.2