linux-kernel - Re: [PATCH v6 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Apr 2021 18:39:03 +0800
From:   Tianling Shen <cnsztl@...il.com>
To:     Pavel Machek <pavel@....cz>
Cc:     Heiko Stuebner <heiko@...ech.de>,
        Marty Jones <mj8263788@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Uwe Kleine-König <uwe@...ine-koenig.org>,
        Jensen Huang <jensenhuang@...endlyarm.com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        David Bauer <mail@...id-bauer.net>,
        Johan Jonker <jbx6244@...il.com>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v6 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S

Hi Pavel,

On Mon, Apr 26, 2021 at 5:33 AM Pavel Machek <pavel@....cz> wrote:
>
> Hi!
>
> > > Changes in v6:
> > > - Fixed format of LED nodes
> > >
> > > Changes in v5:
> > > - Dropped the empty PCIe node
> > > - Dropped useless `/delete-property/`
> > > - Renamed LED nodes
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S
> >       commit: 1003888415e83e15ddb63d1d96189b4f2c5f1d48
> > [2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S
> >       commit: db792e9adbf85ffc9d6b0b060ac3c8e3148c8992
>
> Sorry for late review, but:
>
>
> +                       label = "red:sys";
>
> This should be red:power based on the discussion in earlier threads.

However based on the introduction from FriendlyELEC[1], this is not
the "power" lamp...
"LEDs: 1 x power LED and 3 x GPIO Controlled LED (SYS, LAN, WAN)"

1. https://wiki.friendlyarm.com/wiki/index.php/NanoPi_R4S#Hardware_Spec

Thanks,
Tianling.

>
> Thanks,
>                                                                         Pavel
> --
> http://www.livejournal.com/~pavelmachek