linux-kernel - RE: [PATCH v2] dmaengine: fsl-qdma: check dma_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VE1PR04MB6688E678794C807DD9B18C3289429@VE1PR04MB6688.eurprd04.prod.outlook.com>
Date:   Mon, 26 Apr 2021 00:36:02 +0000
From:   Robin Gong <yibin.gong@....com>
To:     Vinod Koul <vkoul@...nel.org>
CC:     "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] dmaengine: fsl-qdma: check dma_set_mask return value

On 2021/04/26 Vinod Koul <vkoul@...nel.org> wrote: 
> On 23-04-21, 17:29, Robin Gong wrote:
> > For fix warning reported by static code analysis tool like Coverity
> > from Synopsys.
> 
> Please mention which warning, also Coverity id Do see other patches which
> add coverity ids
> 
Okay, would add it in v3, thanks.

> > Signed-off-by: Robin Gong <yibin.gong@....com>
> > ---
> >  drivers/dma/fsl-qdma.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c index
> > ed2ab46..86c02b6 100644
> > --- a/drivers/dma/fsl-qdma.c
> > +++ b/drivers/dma/fsl-qdma.c
> > @@ -1235,7 +1235,11 @@ static int fsl_qdma_probe(struct
> platform_device *pdev)
> >  	fsl_qdma->dma_dev.device_synchronize = fsl_qdma_synchronize;
> >  	fsl_qdma->dma_dev.device_terminate_all = fsl_qdma_terminate_all;
> >
> > -	dma_set_mask(&pdev->dev, DMA_BIT_MASK(40));
> > +	ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(40));
> > +	if (ret) {
> > +		dev_err(&pdev->dev, "dma_set_mask failure.\n");
> > +		return ret;
> > +	}
> >
> >  	platform_set_drvdata(pdev, fsl_qdma);
> >
> > --
> > 2.7.4
> 
> --
> ~Vinod