linux-kernel - Re: [PATCH v10 clocksource 1/7] clocksource: Provide module parameters to inject delays in watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210426040736.GS1401198@tassilo.jf.intel.com>
Date:   Sun, 25 Apr 2021 21:07:36 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     "Paul E. McKenney" <paulmck@...nel.org>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        john.stultz@...aro.org, sboyd@...nel.org, corbet@....net,
        Mark.Rutland@....com, maz@...nel.org, kernel-team@...com,
        neeraju@...eaurora.org, feng.tang@...el.com,
        zhengjun.xing@...el.com, Chris Mason <clm@...com>
Subject: Re: [PATCH v10 clocksource 1/7] clocksource: Provide module
 parameters to inject delays in watchdog

> occur between the reads of the two clocks.  Yes, interrupts are disabled
> across those two reads, but there are no shortage of things that can
> delay interrupts-disabled regions of code ranging from SMI handlers to
> vCPU preemption.  It would be good to have some indication as to why

I assume vCPU preemption here refers to preempt RT? I didn't think
a standard kernel could preempt when interrupt are disabled.

>  
> +	clocksource.inject_delay_period= [KNL]
> +			Number of calls to clocksource_watchdog() before
> +			delays are injected between reads from the
> +			two clocksources.  Values of zero disable this
> +			delay injection.  These delays can cause clocks
> +			to be marked unstable, so use of this parameter
> +			should therefore be avoided on production systems.
> +			Defaults to zero (disabled).
> +
> +	clocksource.inject_delay_repeat= [KNL]
> +			Number of repeated clocksource_watchdog() delay
> +			injections per period.	If inject_delay_period
> +			is five and inject_delay_repeat is three, there
> +			will be five delay-free reads followed by three
> +			delayed reads.

I'm not sure command line options are the right way to do this.
How about integrating it with the fault injection framework in debugfs.

This way syzkaller etc. can play with it, which long term would
give much better test coverage.

This wouldn't allow boot time coverage, but presumably that's not
too important here.

-Andi