linux-kernel - Re: [PATCH v10 clocksource 1/7] clocksource: Provide module parameters to inject delays in watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210426160008.GY1401198@tassilo.jf.intel.com>
Date:   Mon, 26 Apr 2021 09:00:08 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     "Paul E. McKenney" <paulmck@...nel.org>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        john.stultz@...aro.org, sboyd@...nel.org, corbet@....net,
        Mark.Rutland@....com, maz@...nel.org, kernel-team@...com,
        neeraju@...eaurora.org, feng.tang@...el.com,
        zhengjun.xing@...el.com, Chris Mason <clm@...com>
Subject: Re: [PATCH v10 clocksource 1/7] clocksource: Provide module
 parameters to inject delays in watchdog

> Boot-time coverage is important, as we saw in kbuild test robot testing
> of v9 of this patchset, which triggered clocksource_tsc_early, but not
> clocksource_tsc.  Note that v10 avoids this triggering.

Not sure how that could happen, I didn't think the kbuild bot knows
how to set these options.

Overall I think you should follow the existing frame works instead
of inventing your own so that things can be later tested in an
uniform manner.

Perhaps the fault injection framework needs boot options, but
they should be generic.

-Andi