linux-kernel - Re: [PATCH] sound/isa/ib: Fix two use after free in snd_sb_qsound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hzgxl11d5.wl-tiwai@suse.de>
Date:   Mon, 26 Apr 2021 18:01:26 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Lv Yunlong <lyl2019@...l.ustc.edu.cn>
Cc:     perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound/isa/ib: Fix two use after free in snd_sb_qsound_build

On Mon, 26 Apr 2021 16:55:41 +0200,
Lv Yunlong wrote:
> 
> In snd_sb_qsound_build, snd_ctl_add(..,p->qsound_switch...) and
> snd_ctl_add(..,p->qsound_space..) are called. But the second
> arguments of snd_ctl_add() could be freed via snd_ctl_add_replace()
> ->snd_ctl_free_one(). After the error code is returned,
> snd_sb_qsound_destroy(p) is called in __error branch.
> 
> But in snd_sb_qsound_destroy(), the freed p->qsound_switch and
> p->qsound_space are still used by snd_ctl_remove().
> 
> My patch set p->qsound_switch and p->qsound_space to NULL if
> snd_ctl_add() failed to avoid the uaf bugs. But these codes need
> to further be improved with the code style.
> 
> Signed-off-by: Lv Yunlong <lyl2019@...l.ustc.edu.cn>

Thanks, applied now.


Takashi