linux-kernel - Re: [PATCH 083/190] Revert "net: cw1200: fix a NULL pointer dereference"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIhRA6oMozsepir4@kroah.com>
Date:   Tue, 27 Apr 2021 19:59:31 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Kangjie Lu <kjlu@....edu>, Kalle Valo <kvalo@...eaurora.org>
Subject: Re: [PATCH 083/190] Revert "net: cw1200: fix a NULL pointer
 dereference"

On Wed, Apr 21, 2021 at 02:59:18PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 0ed2a005347400500a39ea7c7318f1fea57fb3ca.
> 
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes.  The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
> 
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix.  Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
> 
> Cc: Kangjie Lu <kjlu@....edu>
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/net/wireless/st/cw1200/main.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/net/wireless/st/cw1200/main.c b/drivers/net/wireless/st/cw1200/main.c
> index 326b1cc1d2bc..015dd202e758 100644
> --- a/drivers/net/wireless/st/cw1200/main.c
> +++ b/drivers/net/wireless/st/cw1200/main.c
> @@ -342,11 +342,6 @@ static struct ieee80211_hw *cw1200_init_common(const u8 *macaddr,
>  	mutex_init(&priv->wsm_cmd_mux);
>  	mutex_init(&priv->conf_mutex);
>  	priv->workqueue = create_singlethread_workqueue("cw1200_wq");
> -	if (!priv->workqueue) {
> -		ieee80211_free_hw(hw);
> -		return NULL;
> -	}
> -
>  	sema_init(&priv->scan.lock, 1);
>  	INIT_WORK(&priv->scan.work, cw1200_scan_work);
>  	INIT_DELAYED_WORK(&priv->scan.probe_work, cw1200_probe_work);
> -- 
> 2.31.1
> 

The original here looks correct, dropping this revert.

greg k-h