linux-kernel - RE: [PATCH] sched/fair: don't use waker's cpu if the waker of sync wake-up is interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d057eb13ec4e4643b314dd1652ffa9d4@hisilicon.com>
Date:   Tue, 27 Apr 2021 04:44:32 +0000
From:   "Song Bao Hua (Barry Song)" <song.bao.hua@...ilicon.com>
To:     Mike Galbraith <efault@....de>,
        "vincent.guittot@...aro.org" <vincent.guittot@...aro.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "dietmar.eggemann@....com" <dietmar.eggemann@....com>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>,
        "bsegall@...gle.com" <bsegall@...gle.com>,
        "mgorman@...e.de" <mgorman@...e.de>
CC:     "valentin.schneider@....com" <valentin.schneider@....com>,
        "juri.lelli@...hat.com" <juri.lelli@...hat.com>,
        "bristot@...hat.com" <bristot@...hat.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "xuwei (O)" <xuwei5@...wei.com>,
        "Zengtao (B)" <prime.zeng@...ilicon.com>,
        "guodong.xu@...aro.org" <guodong.xu@...aro.org>,
        yangyicong <yangyicong@...wei.com>,
        "Liguozhu (Kenneth)" <liguozhu@...ilicon.com>,
        "linuxarm@...neuler.org" <linuxarm@...neuler.org>,
        wanghuiqiang <wanghuiqiang@...wei.com>,
        "xieyongjia (A)" <xieyongjia1@...wei.com>
Subject: RE: [PATCH] sched/fair: don't use waker's cpu if the waker of sync
 wake-up is interrupt



> -----Original Message-----
> From: Mike Galbraith [mailto:efault@....de]
> Sent: Tuesday, April 27, 2021 4:22 PM
> To: Song Bao Hua (Barry Song) <song.bao.hua@...ilicon.com>;
> vincent.guittot@...aro.org; mingo@...hat.com; peterz@...radead.org;
> dietmar.eggemann@....com; rostedt@...dmis.org; bsegall@...gle.com;
> mgorman@...e.de
> Cc: valentin.schneider@....com; juri.lelli@...hat.com; bristot@...hat.com;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; xuwei (O)
> <xuwei5@...wei.com>; Zengtao (B) <prime.zeng@...ilicon.com>;
> guodong.xu@...aro.org; yangyicong <yangyicong@...wei.com>; Liguozhu (Kenneth)
> <liguozhu@...ilicon.com>; linuxarm@...neuler.org; wanghuiqiang
> <wanghuiqiang@...wei.com>; xieyongjia (A) <xieyongjia1@...wei.com>
> Subject: Re: [PATCH] sched/fair: don't use waker's cpu if the waker of sync
> wake-up is interrupt
> 
> On Tue, 2021-04-27 at 14:37 +1200, Barry Song wrote:
> >
> > To fix this issue, this patch checks the waker of sync wake-up is a task
> > but not an interrupt. In this case, the waker will schedule out and give
> > CPU to wakee.
> 
> That rash "the waker will schedule out" assumption, ie this really
> really is a synchronous wakeup, may be true in your particular case,

Hi Mike,

For my particular case, sync hint is used by interrupt but not task.
so "the waker will schedule out" is false because the existing task
is relevant at all.

Here the description "the waker will schedule out" is just copying
the general idea of sync wake-up though the real code might overuse
this hint.

> but the sync hint is so overused as to be fairly meaningless. We've
> squabbled with it repeatedly over the years because of that.  It really
> should either become more of a communication of intent than it
> currently is, or just go away.

I agree sync hint might have been overused by other kernel subsystem.
But this patch will at least fix a case: sync waker is interrupt,
in this case, the existing task has nothing to do with waker and wakee,
so this case should be excluded from wake_affine_idle().

> 
> I'd argue for go away, simply because there is no way for the kernel to
> know that there isn't more work directly behind any particular wakeup.

To some extent, "go way" might be a good choice. But this is a more
aggressive action. For those cases waker will really scheduler out,
wakee won't be able to take the advantage of getting the idle cpu
of waker.

> 
> Take a pipe, does shoving some bits through a pipe mean you have no
> further use of your CPU?  IFF you're doing nothing but playing ping-
> pong, sure it does, but how many real proggies have zero overlap among
> its threads of execution?  The mere notion of threaded apps having no
> overlap *to be converted to throughput* is dainbramaged, which should
> be the death knell of the sync wakeup hint.  Threaded apps can't do
> stuff like, oh, networking, which uses the sync hint heavily, without
> at least to some extent defeating the purpose of threading if we were
> to take the hint seriously.  Heck, just look at the beauty (gak) of
> wake_wide().  It was born specifically to combat the pure-evil side of
> the sync wakeup hint.

As above, removing the code of migrating wakee to the cpu of sync waker
could be an option, but needs more investigations.

> 
> Bah, 'nuff "Danger Will Robinson, that thing will *eat you*!!" ;-)
> 
> 	-Mike

Thanks
Barry