linux-kernel - Re: [PATCH bpf-next] libbpf: Fix signed overflow in ringbuf_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4Bzb+OGZrvmgLk3C1bGtmyLU9JiJKp2WfgGkWq0nW0Tq32g@mail.gmail.com>
Date:   Tue, 27 Apr 2021 16:19:16 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     KP Singh <kpsingh@...nel.org>
Cc:     Brendan Jackman <jackmanb@...gle.com>, bpf <bpf@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf-next] libbpf: Fix signed overflow in ringbuf_process_ring

On Tue, Apr 27, 2021 at 4:05 PM KP Singh <kpsingh@...nel.org> wrote:
>
> On Tue, Apr 27, 2021 at 11:34 PM Andrii Nakryiko
> <andrii.nakryiko@...il.com> wrote:
> >
> > On Tue, Apr 27, 2021 at 10:09 AM Brendan Jackman <jackmanb@...gle.com> wrote:
> > >
> > > One of our benchmarks running in (Google-internal) CI pushes data
> > > through the ringbuf faster than userspace is able to consume
> > > it. In this case it seems we're actually able to get >INT_MAX entries
> > > in a single ringbuf_buffer__consume call. ASAN detected that cnt
> > > overflows in this case.
> > >
> > > Fix by just setting a limit on the number of entries that can be
> > > consumed.
> > >
> > > Fixes: bf99c936f947 (libbpf: Add BPF ring buffer support)
> > > Signed-off-by: Brendan Jackman <jackmanb@...gle.com>
> > > ---
> > >  tools/lib/bpf/ringbuf.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/tools/lib/bpf/ringbuf.c b/tools/lib/bpf/ringbuf.c
> > > index e7a8d847161f..445a21df0934 100644
> > > --- a/tools/lib/bpf/ringbuf.c
> > > +++ b/tools/lib/bpf/ringbuf.c
> > > @@ -213,8 +213,8 @@ static int ringbuf_process_ring(struct ring* r)
> > >         do {
> > >                 got_new_data = false;
> > >                 prod_pos = smp_load_acquire(r->producer_pos);
> > > -               while (cons_pos < prod_pos) {
> > > +               /* Don't read more than INT_MAX, or the return vale won't make sense. */
> > > +               while (cons_pos < prod_pos && cnt < INT_MAX) {
> >
> > ring_buffer__pool() is assumed to not return until all the enqueued
> > messages are consumed. That's the requirement for the "adaptive"
> > notification scheme to work properly. So this will break that and
> > cause the next ring_buffer__pool() to never wake up.
> >
> > We could use __u64 internally and then cap it to INT_MAX on return
> > maybe? But honestly, this sounds like an artificial corner case, if
> > you are producing data faster than you can consume it and it goes
> > beyond INT_MAX, something is seriously broken in your application and
>
> Disclaimer: I don't know what Brendan's benchmark is actually doing
>
> That said, I have seen similar boundaries being reached when
> doing process monitoring and then a kernel gets compiled (esp. with ccache)
> and generates a large amount of process events in a very short span of time.
> Another example is when someone runs a short process in a tight while loop.
>
> I agree it's a matter of tuning, but since these corner cases can be
> easily triggered
> even on real (non CI) systems no matter how much one tunes, I wouldn't
> really call it artificial :)

Well of course, given sufficiently active kernel sample producer and
sufficiently slow consumer you can keep consuming forever.

I think we have two alternatives here:
1) consume all but cap return to INT_MAX
2) consume all but return long long as return result

Third alternative is to have another API with maximum number of
samples to consume. But then user needs to know what they are doing
(e.g., they do FORCE on BPF side, or they do their own epoll_wait, or
they do ring_buffer__poll with timeout = 0, etc).

I'm just not sure anyone would want to understand all the
implications. And it's easy to miss those implications. So maybe let's
do long long (or __s64) return type instead?

>
> - KP
>
> > you have more important things to handle :)
> >
> > >                         len_ptr = r->data + (cons_pos & r->mask);
> > >                         len = smp_load_acquire(len_ptr);
> > >
> > > --
> > > 2.31.1.498.g6c1eba8ee3d-goog
> > >