linux-kernel - RE: [PATCH 1/2] thermal: imx_sc: add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 27 Apr 2021 08:55:36 +0000
From:   Jacky Bai <ping.bai@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Zhang Rui <rui.zhang@...el.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang7@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] thermal: imx_sc: add missing of_node_put for loop
 iteration

> Subject: [PATCH 1/2] thermal: imx_sc: add missing of_node_put for loop
> iteration
> 
> Early exits from for_each_available_child_of_node() should decrement the
> node reference counter.  Reported by Coccinelle:
> 
>   drivers/thermal/imx_sc_thermal.c:93:1-33: WARNING:
>     Function "for_each_available_child_of_node" should have of_node_put()
> before return around line 97.
> 

Reviewed-by: Jacky Bai <ping.bai@....com>

BR
Jacky Bai

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---
>  drivers/thermal/imx_sc_thermal.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/thermal/imx_sc_thermal.c
> b/drivers/thermal/imx_sc_thermal.c
> index b01d28eca7ee..8d76dbfde6a9 100644
> --- a/drivers/thermal/imx_sc_thermal.c
> +++ b/drivers/thermal/imx_sc_thermal.c
> @@ -93,6 +93,7 @@ static int imx_sc_thermal_probe(struct platform_device
> *pdev)
>  	for_each_available_child_of_node(np, child) {
>  		sensor = devm_kzalloc(&pdev->dev, sizeof(*sensor), GFP_KERNEL);
>  		if (!sensor) {
> +			of_node_put(child);
>  			of_node_put(sensor_np);
>  			return -ENOMEM;
>  		}
> @@ -104,6 +105,7 @@ static int imx_sc_thermal_probe(struct
> platform_device *pdev)
>  			dev_err(&pdev->dev,
>  				"failed to get valid sensor resource id: %d\n",
>  				ret);
> +			of_node_put(child);
>  			break;
>  		}
> 
> @@ -114,6 +116,7 @@ static int imx_sc_thermal_probe(struct
> platform_device *pdev)
>  		if (IS_ERR(sensor->tzd)) {
>  			dev_err(&pdev->dev, "failed to register thermal zone\n");
>  			ret = PTR_ERR(sensor->tzd);
> +			of_node_put(child);
>  			break;
>  		}
> 
> --
> 2.25.1