linux-kernel - Re: [PATCH] nvmem: qfprom: minor nit fixes, no functional change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <561f49745182ce6a13a2456e263c1b0cc572ab27.camel@perches.com>
Date:   Mon, 26 Apr 2021 19:37:56 -0700
From:   Joe Perches <joe@...ches.com>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Rajendra Nayak <rnayak@...eaurora.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "Ravi Kumar Bokka (Temp)" <rbokka@...eaurora.org>
Subject: Re: [PATCH] nvmem: qfprom: minor nit fixes, no functional change

On Mon, 2021-04-26 at 08:11 -0700, Doug Anderson wrote:
> Hi,
> 
> On Fri, Apr 23, 2021 at 8:13 AM Joe Perches <joe@...ches.com> wrote:
> > 
> > On Fri, 2021-04-23 at 12:35 +0530, Rajendra Nayak wrote:
> > > Fix a missed newline, and update a comment which is stale
> > > after the merge of '5a1bea2a: nvmem: qfprom: Add support for fuse
> > > blowing on sc7280'
> > > No other functional change in this patch.
> > []
> > > diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
> > []
> > > @@ -195,7 +196,7 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,
> > >       }
> > > 
> > >       /*
> > > -      * Hardware requires 1.8V min for fuse blowing; this may be
> > > +      * Hardware requires a min voltage for fuse blowing; this may be
> > >        * a rail shared do don't specify a max--regulator constraints
> > 
> >                          so don't?
> > 
> > >        * will handle.
> > >        */
> > 
> > but the comment doesn't make much overall sense to me.
> 
> What part of it doesn't make sense, exactly?

max--regulator

I think that should be something like:

	Hardware requires a minimum voltage for fuse blowing.
	This may be a shared rail so don't specify a maximum.
	Regulator constraints will handle (what exactly, it?)