linux-kernel - Re: [PATCH] mm: append __GFP_COMP flag for trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210427025358.GV235567@casper.infradead.org>
Date:   Tue, 27 Apr 2021 03:53:58 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Xiongwei Song <sxwjean@...com>
Cc:     cl@...ux.com, penberg@...nel.org, rientjes@...gle.com,
        iamjoonsoo.kim@....com, akpm@...ux-foundation.org, vbabka@...e.cz,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Xiongwei Song <sxwjean@...il.com>
Subject: Re: [PATCH] mm: append __GFP_COMP flag for trace_malloc

On Tue, Apr 27, 2021 at 10:43:20AM +0800, Xiongwei Song wrote:
> From: Xiongwei Song <sxwjean@...il.com>
> 
> When calling kmalloc_order, the flags should include __GFP_COMP here,
> so that trace_malloc can trace the precise flags.

I suppose that depends on your point of view.  Should we report the
flags used by the caller, or the flags that we used to allocate memory?
And why does it matter?