linux-kernel - Re: [PATCH 1/2] ALSA: pcm: Add support for 705.6KHz and 768KHz sample rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hpmygyp2x.wl-tiwai@suse.de>
Date:   Tue, 27 Apr 2021 12:55:02 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Shengjiu Wang <shengjiu.wang@....com>
Cc:     perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, broonie@...nel.org
Subject: Re: [PATCH 1/2] ALSA: pcm: Add support for 705.6KHz and 768KHz sample rate

On Tue, 27 Apr 2021 12:34:22 +0200,
Shengjiu Wang wrote:
> 
> Some high resolution codecs support 705.6KHz and 768KHz rates.
> So extend supported sample rate to 768kHz in pcm.h.
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>

How many devices require it for now?

I don't want to extend the core definitions blindly unless those rates
are really commonly used.  You can add those specific rates in the
codec driver instead.


thanks,

Takashi

> ---
>  include/sound/pcm.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/sound/pcm.h b/include/sound/pcm.h
> index 2e1200d17d0c..88056824ffec 100644
> --- a/include/sound/pcm.h
> +++ b/include/sound/pcm.h
> @@ -121,6 +121,8 @@ struct snd_pcm_ops {
>  #define SNDRV_PCM_RATE_192000		(1<<12)		/* 192000Hz */
>  #define SNDRV_PCM_RATE_352800		(1<<13)		/* 352800Hz */
>  #define SNDRV_PCM_RATE_384000		(1<<14)		/* 384000Hz */
> +#define SNDRV_PCM_RATE_705600		(1<<15)		/* 705600Hz */
> +#define SNDRV_PCM_RATE_768000		(1<<16)		/* 768000Hz */
>  
>  #define SNDRV_PCM_RATE_CONTINUOUS	(1<<30)		/* continuous range */
>  #define SNDRV_PCM_RATE_KNOT		(1<<31)		/* supports more non-continuos rates */
> @@ -136,6 +138,9 @@ struct snd_pcm_ops {
>  #define SNDRV_PCM_RATE_8000_384000	(SNDRV_PCM_RATE_8000_192000|\
>  					 SNDRV_PCM_RATE_352800|\
>  					 SNDRV_PCM_RATE_384000)
> +#define SNDRV_PCM_RATE_8000_768000	(SNDRV_PCM_RATE_8000_768000|\
> +					 SNDRV_PCM_RATE_705600|\
> +					 SNDRV_PCM_RATE_768000)
>  #define _SNDRV_PCM_FMTBIT(fmt)		(1ULL << (__force int)SNDRV_PCM_FORMAT_##fmt)
>  #define SNDRV_PCM_FMTBIT_S8		_SNDRV_PCM_FMTBIT(S8)
>  #define SNDRV_PCM_FMTBIT_U8		_SNDRV_PCM_FMTBIT(U8)
> -- 
> 2.27.0
>