linux-kernel - Re: [PATCH v2 00/50] staging: rtl8723bs: remove all remaining debug macros in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIfwL3s5hdRTCNrm@kroah.com>
Date:   Tue, 27 Apr 2021 13:06:23 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Fabio Aiuto <fabioaiuto83@...il.com>
Cc:     joe@...ches.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 00/50] staging: rtl8723bs: remove all remaining debug
 macros in rtw_debug.h

On Sat, Apr 24, 2021 at 11:01:43AM +0200, Fabio Aiuto wrote:
> This patchset removes all remaining debug macros in rtw_debug.h
> 
> DBG_871X_SEL macro is replaced with netdev_dbg() for it does
> a raw printk call which is not best recommended for a driver.
> 
> @@
> expression sel;
> expression list args;
> identifier padapter;
> identifier func;
> @@
> 
> func(..., struct adapter *padapter, ...) {
>         <...
> -       DBG_871X_SEL(sel, args);
> +       netdev_dbg(padapter->pnetdev, args);
>         ...>
> 
> unused _DBG_871X_LEVEL macro declaration is removed.
> 
> Beautified register dump in core/rtw_debug.c 
> 
> Some code cleaning is done and all other private component tracing
> macros are removed.

Nice work, thanks for doing all of this!  Now queued up for 5.14-rc1.

greg k-h