linux-kernel - Re: Re: [PATCH] spi: imx: add a check for speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210427111233.GD4605@sirena.org.uk>
Date:   Tue, 27 Apr 2021 12:12:33 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Clark Wang <xiaoning.wang@....com>
Cc:     "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH] spi: imx: add a check for speed_hz before
 calculating the clock

On Tue, Apr 27, 2021 at 08:33:06AM +0000, Clark Wang wrote:

> However, I notice that you have applied this patch to the next branch?
> Will you revert this patch?

Well, it's redundant but not harmful.

> I think you may want to apply this patch I sent before.
> 
> Author: Clark Wang <xiaoning.wang@....com>
> Date:   Mon Dec 14 17:05:04 2020 +0800
> 
>     spi: imx: add 16/32 bits per word support for slave mode
>     
>     Enable 16/32 bits per word support for spi-imx slave mode.
>     It only support 8 bits per word in slave mode before.

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)