linux-kernel - [PATCH] drivers/rapidio/rio-scan.c: drop unneeded assignment in rio_enum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 27 Apr 2021 19:23:15 +0800
From:   Yang Li <yang.lee@...ux.alibaba.com>
To:     mporter@...nel.crashing.org
Cc:     alex.bou9@...il.com, linux-kernel@...r.kernel.org,
        Yang Li <yang.lee@...ux.alibaba.com>
Subject: [PATCH] drivers/rapidio/rio-scan.c: drop unneeded assignment in rio_enum_peer()

Making '<' operation with port->host_deviceid directly after
calling the function rio_get_host_deviceid_lock(() is more efficient,
so assignment to ‘tmp’ is redundant.

Eliminate the following clang_analyzer warning:
drivers/rapidio/rio-scan.c:561:10: warning: Although the value stored to
'tmp' is used in the enclosing expression, the value is never actually
read from 'tmp'

No functional change.

Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
---
 drivers/rapidio/rio-scan.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/rapidio/rio-scan.c b/drivers/rapidio/rio-scan.c
index 19b0c33..2bc4d1e 100644
--- a/drivers/rapidio/rio-scan.c
+++ b/drivers/rapidio/rio-scan.c
@@ -524,7 +524,6 @@ static int rio_enum_peer(struct rio_net *net, struct rio_mport *port,
 {
 	struct rio_dev *rdev;
 	u32 regval;
-	int tmp;
 
 	if (rio_mport_chk_dev_access(port,
 			RIO_ANY_DESTID(port->sys_size), hopcount)) {
@@ -558,7 +557,7 @@ static int rio_enum_peer(struct rio_net *net, struct rio_mport *port,
 	rio_mport_write_config_32(port, RIO_ANY_DESTID(port->sys_size),
 				  hopcount,
 				  RIO_HOST_DID_LOCK_CSR, port->host_deviceid);
-	while ((tmp = rio_get_host_deviceid_lock(port, hopcount))
+	while (rio_get_host_deviceid_lock(port, hopcount)
 	       < port->host_deviceid) {
 		/* Delay a bit */
 		mdelay(1);
-- 
1.8.3.1