lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Apr 2021 09:00:12 +0530 From: Anshuman Khandual <anshuman.khandual@....com> To: "Matthew Wilcox (Oracle)" <willy@...radead.org>, linux-mm@...ck.org Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/6] mm: Make __dump_page static On 4/17/21 4:45 AM, Matthew Wilcox (Oracle) wrote: > The only caller of __dump_page() now opencodes dump_page(), so > remove it as an externally visible symbol. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org> > --- > include/linux/mmdebug.h | 3 +-- > mm/debug.c | 2 +- > mm/page_alloc.c | 3 +-- > 3 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h > index 5d0767cb424a..1935d4c72d10 100644 > --- a/include/linux/mmdebug.h > +++ b/include/linux/mmdebug.h > @@ -9,8 +9,7 @@ struct page; > struct vm_area_struct; > struct mm_struct; > > -extern void dump_page(struct page *page, const char *reason); > -extern void __dump_page(struct page *page, const char *reason); > +void dump_page(struct page *page, const char *reason); > void dump_vma(const struct vm_area_struct *vma); > void dump_mm(const struct mm_struct *mm); > > diff --git a/mm/debug.c b/mm/debug.c > index 0bdda8407f71..84cdcd0f7bd3 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -42,7 +42,7 @@ const struct trace_print_flags vmaflag_names[] = { > {0, NULL} > }; > > -void __dump_page(struct page *page, const char *reason) > +static void __dump_page(struct page *page, const char *reason) > { > struct page *head = compound_head(page); > struct address_space *mapping; > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 5a35f21b57c6..0152670c6f04 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -658,8 +658,7 @@ static void bad_page(struct page *page, const char *reason) > > pr_alert("BUG: Bad page state in process %s pfn:%05lx\n", > current->comm, page_to_pfn(page)); > - __dump_page(page, reason); > - dump_page_owner(page); > + dump_page(page, reason); > > print_modules(); > dump_stack(); > Reviewed-by: Anshuman Khandual <anshuman.khandual@....com>
Powered by blists - more mailing lists