linux-kernel - Re: [PATCH 190/190] Revert "ethtool: fix a potential missing-check bug"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIf78yOIngfXOxjA@kroah.com>
Date:   Tue, 27 Apr 2021 13:56:35 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     James Morris <jmorris@...ei.org>
Cc:     linux-kernel@...r.kernel.org, Wenwen Wang <wang6495@....edu>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH 190/190] Revert "ethtool: fix a potential missing-check
 bug"

On Thu, Apr 22, 2021 at 06:06:59AM +1000, James Morris wrote:
> On Wed, 21 Apr 2021, Greg Kroah-Hartman wrote:
> 
> > This reverts commit d656fe49e33df48ee6bc19e871f5862f49895c9e.
> > 
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes.  The result of these submissions can be found in a
> > paper published at the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota).
> > 
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix.  Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> > 
> > Cc: Wenwen Wang <wang6495@....edu>
> > Cc: David S. Miller <davem@...emloft.net>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> The original patch looks valid and fixes a race. 

Thanks for reviewing, now dropped.

greg k-h