linux-kernel - [PATCH 5.13] io_uring: Check current->io_uring in io_uring_cancel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210427125148.21816-1-hello@oswalpalash.com>
Date:   Tue, 27 Apr 2021 18:21:49 +0530
From:   Palash Oswal <hello@...alpalash.com>
To:     asml.silence@...il.com
Cc:     axboe@...nel.dk, dvyukov@...gle.com, io-uring@...r.kernel.org,
        linux-kernel@...r.kernel.org, oswalpalash@...il.com,
        syzbot+be51ca5a4d97f017cd50@...kaller.appspotmail.com,
        syzkaller-bugs@...glegroups.com,
        Palash Oswal <hello@...alpalash.com>, stable@...r.kernel.org
Subject: [PATCH 5.13] io_uring: Check current->io_uring in io_uring_cancel_sqpoll

syzkaller identified KASAN: null-ptr-deref Write in
io_uring_cancel_sqpoll on v5.12

io_uring_cancel_sqpoll is called by io_sq_thread before calling
io_uring_alloc_task_context. This leads to current->io_uring being
NULL. io_uring_cancel_sqpoll should not have to deal with threads
where current->io_uring is NULL.

In order to cast a wider safety net, perform input sanitisation
directly in io_uring_cancel_sqpoll and return for NULL value of
current->io_uring.

Reported-by: syzbot+be51ca5a4d97f017cd50@...kaller.appspotmail.com
Cc: stable@...r.kernel.org
Signed-off-by: Palash Oswal <hello@...alpalash.com>
---
 fs/io_uring.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index dff34975d86b..eccad51b7954 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -8998,6 +8998,8 @@ static void io_uring_cancel_sqpoll(struct io_ring_ctx *ctx)
 	s64 inflight;
 	DEFINE_WAIT(wait);
 
+	if (!current->io_uring)
+		return;
 	WARN_ON_ONCE(!sqd || ctx->sq_data->thread != current);
 
 	atomic_inc(&tctx->in_idle);
-- 
2.27.0