linux-kernel - Re: [PATCH 152/190] Revert "media: usb: gspca: add a missed check for goto_low

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIgPbVT+Tj1F9KRE@kroah.com>
Date:   Tue, 27 Apr 2021 15:19:41 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Kangjie Lu <kjlu@....edu>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
Subject: Re: [PATCH 152/190] Revert "media: usb: gspca: add a missed check
 for goto_low_power"

On Wed, Apr 21, 2021 at 03:00:27PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 5b711870bec4dc9a6d705d41e127e73944fa3650.
> 
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes.  The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
> 
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix.  Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
> 
> Cc: Kangjie Lu <kjlu@....edu>
> Cc: Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/media/usb/gspca/cpia1.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/media/usb/gspca/cpia1.c b/drivers/media/usb/gspca/cpia1.c
> index a4f7431486f3..d93d384286c1 100644
> --- a/drivers/media/usb/gspca/cpia1.c
> +++ b/drivers/media/usb/gspca/cpia1.c
> @@ -1424,7 +1424,6 @@ static int sd_config(struct gspca_dev *gspca_dev,
>  {
>  	struct sd *sd = (struct sd *) gspca_dev;
>  	struct cam *cam;
> -	int ret;
>  
>  	sd->mainsFreq = FREQ_DEF == V4L2_CID_POWER_LINE_FREQUENCY_60HZ;
>  	reset_camera_params(gspca_dev);
> @@ -1436,10 +1435,7 @@ static int sd_config(struct gspca_dev *gspca_dev,
>  	cam->cam_mode = mode;
>  	cam->nmodes = ARRAY_SIZE(mode);
>  
> -	ret = goto_low_power(gspca_dev);
> -	if (ret)
> -		gspca_err(gspca_dev, "Cannot go to low power mode: %d\n",
> -			  ret);
> +	goto_low_power(gspca_dev);
>  	/* Check the firmware version. */
>  	sd->params.version.firmwareVersion = 0;
>  	get_version_information(gspca_dev);
> -- 
> 2.31.1
> 

The original commit here did nothing useful, so I am going to keep this
revert.

greg k-h