linux-kernel - Re: [PATCH 149/190] Revert "media: lgdt3306a: fix a missing check of return value"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Apr 2021 15:27:45 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Kangjie Lu <kjlu@....edu>, Sean Young <sean@...s.org>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
Subject: Re: [PATCH 149/190] Revert "media: lgdt3306a: fix a missing check of
 return value"

On Wed, Apr 21, 2021 at 03:00:24PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit c9b7d8f252a5a6f8ca6e948151367cbc7bc4b776.
> 
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes.  The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
> 
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix.  Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
> 
> Cc: Kangjie Lu <kjlu@....edu>
> Cc: Sean Young <sean@...s.org>
> Cc: Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/media/dvb-frontends/lgdt3306a.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c
> index 722576f1732a..f34263a33ede 100644
> --- a/drivers/media/dvb-frontends/lgdt3306a.c
> +++ b/drivers/media/dvb-frontends/lgdt3306a.c
> @@ -1690,10 +1690,7 @@ static int lgdt3306a_read_signal_strength(struct dvb_frontend *fe,
>  	case QAM_256:
>  	case QAM_AUTO:
>  		/* need to know actual modulation to set proper SNR baseline */
> -		ret = lgdt3306a_read_reg(state, 0x00a6, &val);
> -		if (lg_chkerr(ret))
> -			goto fail;
> -
> +		lgdt3306a_read_reg(state, 0x00a6, &val);
>  		if(val & 0x04)
>  			ref_snr = 2800; /* QAM-256 28dB */
>  		else
> -- 
> 2.31.1
> 

Odd that this was the only fixup for this file, for this specific issue,
there are other places in this driver that this same change is needed.
That shows someone is not actually using a sane tool to create these :(

But it's ok as-is, I'll drop the revert.

greg k-h