linux-kernel - Re: [PATCH 146/190] Revert "media: dvb: Add check on sp8870

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIgSIoBZ7pW78u2d@kroah.com>
Date:   Tue, 27 Apr 2021 15:31:14 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Aditya Pakki <pakki001@....edu>, Sean Young <sean@...s.org>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
Subject: Re: [PATCH 146/190] Revert "media: dvb: Add check on sp8870_readreg"

On Wed, Apr 21, 2021 at 03:00:21PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 467a37fba93f2b4fe3ab597ff6a517b22b566882.
> 
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes.  The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
> 
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix.  Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
> 
> Cc: Aditya Pakki <pakki001@....edu>
> Cc: Sean Young <sean@...s.org>
> Cc: Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/media/dvb-frontends/sp8870.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/dvb-frontends/sp8870.c b/drivers/media/dvb-frontends/sp8870.c
> index 655db8272268..ee893a2f2261 100644
> --- a/drivers/media/dvb-frontends/sp8870.c
> +++ b/drivers/media/dvb-frontends/sp8870.c
> @@ -280,9 +280,7 @@ static int sp8870_set_frontend_parameters(struct dvb_frontend *fe)
>  	sp8870_writereg(state, 0xc05, reg0xc05);
>  
>  	// read status reg in order to clear pending irqs
> -	err = sp8870_readreg(state, 0x200);
> -	if (err)
> -		return err;
> +	sp8870_readreg(state, 0x200);
>  
>  	// system controller start
>  	sp8870_microcontroller_start(state);
> -- 
> 2.31.1
> 

This change looks to break the driver entirely, I guess no one uses it
anymore.  It should have checked for < 0 if it actually cared about the
result.

I'll keep this as it is not correct.

thanks,

greg k-h