linux-kernel - Re: [PATCH 022/190] Revert "drm/radeon: Fix reference count leaks caused by pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIgUacSD2nVPL24c@kroah.com>
Date:   Tue, 27 Apr 2021 15:40:57 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Deucher, Alexander" <Alexander.Deucher@....com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Quan, Evan" <Evan.Quan@....com>, Aditya Pakki <pakki001@....edu>
Subject: Re: [PATCH 022/190] Revert "drm/radeon: Fix reference count leaks
 caused by pm_runtime_get_sync"

On Wed, Apr 21, 2021 at 04:08:05PM +0000, Deucher, Alexander wrote:
> [AMD Public Use]
> 
> > -----Original Message-----
> > From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Sent: Wednesday, April 21, 2021 8:58 AM
> > To: linux-kernel@...r.kernel.org
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; Quan, Evan
> > <Evan.Quan@....com>; Aditya Pakki <pakki001@....edu>; Deucher,
> > Alexander <Alexander.Deucher@....com>
> > Subject: [PATCH 022/190] Revert "drm/radeon: Fix reference count leaks
> > caused by pm_runtime_get_sync"
> > 
> > This reverts commit 9fb10671011143d15b6b40d6d5fa9c52c57e9d63.
> > 
> > Commits from @umn.edu addresses have been found to be submitted in
> > "bad faith" to try to test the kernel community's ability to review "known
> > malicious" changes.  The result of these submissions can be found in a paper
> > published at the 42nd IEEE Symposium on Security and Privacy entitled,
> > "Open Source Insecurity: Stealthily Introducing Vulnerabilities via Hypocrite
> > Commits" written by Qiushi Wu (University of Minnesota) and Kangjie Lu
> > (University of Minnesota).
> > 
> > Because of this, all submissions from this group must be reverted from the
> > kernel tree and will need to be re-reviewed again to determine if they
> > actually are a valid fix.  Until that work is complete, remove this change to
> > ensure that no problems are being introduced into the codebase.
> > 
> > Cc: Evan Quan <evan.quan@....com>
> > Cc: Aditya Pakki <pakki001@....edu>
> > Cc: Alex Deucher <alexander.deucher@....com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> AFAICT, this patch is correct or at least does no harm.  Handling of pm_runtime_get_sync() errors in the kernel seems to be inconsistent at best.

Thanks for the review, I'll drop this revert from the tree.

greg k-h