lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210427144904.GB202505@roeck-us.net>
Date:   Tue, 27 Apr 2021 07:49:04 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Wilken Gottwalt <wilken.gottwalt@...teo.net>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, kael_w@...h.net
Subject: Re: [PATCH] hwmon: Remove unneeded semicolons

Hi,

On Tue, Apr 27, 2021 at 12:42:19PM +0800, Wan Jiabing wrote:
> Fix the following coccicheck warning:
> 
> ./drivers/hwmon/corsair-psu.c:379:2-3: Unneeded semicolon
> 
> Remove unneeded semicolons.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>

Thanks a lot for your patch; applied.

In the future, please add the affected driver to the subject line, as in

hwmon: (corsair-psu) ...

Thanks,
Guenter

> ---
>  drivers/hwmon/corsair-psu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c
> index 3a5807e4a2ef..02298b86b57b 100644
> --- a/drivers/hwmon/corsair-psu.c
> +++ b/drivers/hwmon/corsair-psu.c
> @@ -355,7 +355,7 @@ static umode_t corsairpsu_hwmon_power_is_visible(const struct corsairpsu_data *p
>  		return 0444;
>  	default:
>  		return 0;
> -	};
> +	}
>  }
>  
>  static umode_t corsairpsu_hwmon_in_is_visible(const struct corsairpsu_data *priv, u32 attr,
> @@ -376,7 +376,7 @@ static umode_t corsairpsu_hwmon_in_is_visible(const struct corsairpsu_data *priv
>  		break;
>  	default:
>  		break;
> -	};
> +	}
>  
>  	return res;
>  }
> -- 
> 2.25.1
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ