linux-kernel - Re: [PATCH 032/190] Revert "ASoC: img-parallel-out: Fix a reference count leak"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIg7plCKyGRcx582@kroah.com>
Date:   Tue, 27 Apr 2021 18:28:22 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Qiushi Wu <wu000273@....edu>, Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH 032/190] Revert "ASoC: img-parallel-out: Fix a reference
 count leak"

On Wed, Apr 21, 2021 at 02:58:27PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 6b9fbb073636906eee9fe4d4c05a4f445b9e2a23.
> 
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes.  The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
> 
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix.  Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
> 
> Cc: Qiushi Wu <wu000273@....edu>
> Cc: https
> Cc: Mark Brown <broonie@...nel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  sound/soc/img/img-parallel-out.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/sound/soc/img/img-parallel-out.c b/sound/soc/img/img-parallel-out.c
> index 4da49a42e854..5ddbe3a31c2e 100644
> --- a/sound/soc/img/img-parallel-out.c
> +++ b/sound/soc/img/img-parallel-out.c
> @@ -163,10 +163,8 @@ static int img_prl_out_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
>  	}
>  
>  	ret = pm_runtime_get_sync(prl->dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(prl->dev);
> +	if (ret < 0)
>  		return ret;
> -	}
>  
>  	reg = img_prl_out_readl(prl, IMG_PRL_OUT_CTL);
>  	reg = (reg & ~IMG_PRL_OUT_CTL_EDGE_MASK) | control_set;
> -- 
> 2.31.1
> 

Looks correct, dropping.