linux-kernel - Re: [PATCH 036/190] Revert "vfio/mdev: Fix reference count leak in add_mdev_supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIg956FLPrswQr3p@kroah.com>
Date:   Tue, 27 Apr 2021 18:37:59 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     Jason Gunthorpe <jgg@...dia.com>, linux-kernel@...r.kernel.org,
        Qiushi Wu <wu000273@....edu>,
        Cornelia Huck <cohuck@...hat.com>,
        Kirti Wankhede <kwankhede@...dia.com>
Subject: Re: [PATCH 036/190] Revert "vfio/mdev: Fix reference count leak in
 add_mdev_supported_type"

On Wed, Apr 21, 2021 at 05:03:59PM -0600, Alex Williamson wrote:
> On Wed, 21 Apr 2021 15:36:34 -0300
> Jason Gunthorpe <jgg@...dia.com> wrote:
> 
> > On Wed, Apr 21, 2021 at 02:58:31PM +0200, Greg Kroah-Hartman wrote:
> > > This reverts commit aa8ba13cae3134b8ef1c1b6879f66372531da738.
> > > 
> > > Commits from @umn.edu addresses have been found to be submitted in "bad
> > > faith" to try to test the kernel community's ability to review "known
> > > malicious" changes.  The result of these submissions can be found in a
> > > paper published at the 42nd IEEE Symposium on Security and Privacy
> > > entitled, "Open Source Insecurity: Stealthily Introducing
> > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > > of Minnesota) and Kangjie Lu (University of Minnesota).
> > > 
> > > Because of this, all submissions from this group must be reverted from
> > > the kernel tree and will need to be re-reviewed again to determine if
> > > they actually are a valid fix.  Until that work is complete, remove this
> > > change to ensure that no problems are being introduced into the
> > > codebase.
> > > 
> > > Cc: Qiushi Wu <wu000273@....edu>
> > > Cc: Cornelia Huck <cohuck@...hat.com>
> > > Cc: Kirti Wankhede <kwankhede@...dia.com>
> > > Cc: Alex Williamson <alex.williamson@...hat.com>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > ---
> > >  drivers/vfio/mdev/mdev_sysfs.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)  
> > 
> > I recently audited all of this mdev stuff, the original patch is OK,
> > though I would have written it with a goto. Please don't revert it.
> 
> Agreed, the original commit looks correct.  Thanks,

Thanks to both of you for the review, I'll drop my revert from my tree.

greg k-h