linux-kernel - Re: [PATCH 170/190] Revert "net: dsa: bcm_sf2: Propagate error value from mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIhA0zGpWSUSjZKH@kroah.com>
Date:   Tue, 27 Apr 2021 18:50:27 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     linux-kernel@...r.kernel.org, Kangjie Lu <kjlu@....edu>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH 170/190] Revert "net: dsa: bcm_sf2: Propagate error value
 from mdio_write"

On Wed, Apr 21, 2021 at 04:20:24PM -0700, Florian Fainelli wrote:
> 
> 
> On 4/21/2021 6:00 AM, Greg Kroah-Hartman wrote:
> > This reverts commit e49505f7255be8ced695919c08a29bf2c3d79616.
> > 
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes.  The result of these submissions can be found in a
> > paper published at the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota).
> > 
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix.  Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> > 
> > Cc: Kangjie Lu <kjlu@....edu>
> > Cc: David S. Miller <davem@...emloft.net>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> While this commit does not fix a known problem, the driver should have
> arguably propagated the return values and it did not, so I would be
> inclined to keep it.

Looks good, I'll drop my revert, thanks for the review.

greg k-h