linux-kernel - Re: [PATCH 188/190] Revert "scsi: 3w-xxxx: fix a missing-check bug"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIhCLuJi3WyuMS0T@kroah.com>
Date:   Tue, 27 Apr 2021 18:56:14 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Wenwen Wang <wang6495@....edu>, Adam Radford <aradford@...il.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH 188/190] Revert "scsi: 3w-xxxx: fix a missing-check bug"

On Wed, Apr 21, 2021 at 03:01:03PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 9899e4d3523faaef17c67141aa80ff2088f17871.
> 
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes.  The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
> 
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix.  Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
> 
> Cc: Wenwen Wang <wang6495@....edu>
> Cc: Adam Radford <aradford@...il.com>
> Cc: Martin K. Petersen <martin.petersen@...cle.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/scsi/3w-xxxx.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/scsi/3w-xxxx.c b/drivers/scsi/3w-xxxx.c
> index d90b9fca4aea..8f52f35e40f1 100644
> --- a/drivers/scsi/3w-xxxx.c
> +++ b/drivers/scsi/3w-xxxx.c
> @@ -1035,9 +1035,6 @@ static int tw_chrdev_open(struct inode *inode, struct file *file)
>  
>  	dprintk(KERN_WARNING "3w-xxxx: tw_ioctl_open()\n");
>  
> -	if (!capable(CAP_SYS_ADMIN))
> -		return -EACCES;
> -
>  	minor_number = iminor(inode);
>  	if (minor_number >= tw_device_extension_count)
>  		return -ENODEV;
> -- 
> 2.31.1
> 

The original commit was correct, dropping this revert.

greg k-h