linux-kernel - Re: [PATCH 184/190] Revert "yam: fix a missing-check bug"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIhCbigynlBTvbZs@kroah.com>
Date:   Tue, 27 Apr 2021 18:57:18 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Wenwen Wang <wang6495@....edu>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH 184/190] Revert "yam: fix a missing-check bug"

On Wed, Apr 21, 2021 at 03:00:59PM +0200, Greg Kroah-Hartman wrote:
> This reverts commit 0781168e23a2fc8dceb989f11fc5b39b3ccacc35.
> 
> Commits from @umn.edu addresses have been found to be submitted in "bad
> faith" to try to test the kernel community's ability to review "known
> malicious" changes.  The result of these submissions can be found in a
> paper published at the 42nd IEEE Symposium on Security and Privacy
> entitled, "Open Source Insecurity: Stealthily Introducing
> Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> of Minnesota) and Kangjie Lu (University of Minnesota).
> 
> Because of this, all submissions from this group must be reverted from
> the kernel tree and will need to be re-reviewed again to determine if
> they actually are a valid fix.  Until that work is complete, remove this
> change to ensure that no problems are being introduced into the
> codebase.
> 
> Cc: Wenwen Wang <wang6495@....edu>
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/net/hamradio/yam.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c
> index 5ab53e9942f3..616db3a0d2f4 100644
> --- a/drivers/net/hamradio/yam.c
> +++ b/drivers/net/hamradio/yam.c
> @@ -951,8 +951,6 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
>  				 sizeof(struct yamdrv_ioctl_mcs));
>  		if (IS_ERR(ym))
>  			return PTR_ERR(ym);
> -		if (ym->cmd != SIOCYAMSMCS)
> -			return -EINVAL;
>  		if (ym->bitrate > YAM_MAXBITRATE) {
>  			kfree(ym);
>  			return -EINVAL;
> @@ -968,8 +966,6 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
>  		if (copy_from_user(&yi, ifr->ifr_data, sizeof(struct yamdrv_ioctl_cfg)))
>  			 return -EFAULT;
>  
> -		if (yi.cmd != SIOCYAMSCFG)
> -			return -EINVAL;
>  		if ((yi.cfg.mask & YAM_IOBASE) && netif_running(dev))
>  			return -EINVAL;		/* Cannot change this parameter when up */
>  		if ((yi.cfg.mask & YAM_IRQ) && netif_running(dev))
> -- 
> 2.31.1
> 

Original looks correct, dropping this revert.

greg k-h