[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202104290331.tfwbdGzt-lkp@intel.com>
Date: Thu, 29 Apr 2021 03:44:22 +0800
From: kernel test robot <lkp@...el.com>
To: Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: kbuild-all@...ts.01.org, linux-media@...r.kernel.org,
linuxarm@...wei.com, mauro.chehab@...wei.com,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Ezequiel Garcia <ezequiel@...labora.com>,
Hans Verkuil <hverkuil@...all.nl>,
Krzysztof Kozlowski <krzk@...nel.org>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v4 07/79] media: exynos-gsc: don't resume at remove time
Hi Mauro,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on rockchip/for-next tegra/for-next v5.12 next-20210428]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Address-some-issues-with-PM-runtime-at-media-subsystem/20210428-225742
base: git://linuxtv.org/media_tree.git master
config: nds32-randconfig-r035-20210428 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/b6dba4aea621c15b0aa6f92e548c74cd6994eb20
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mauro-Carvalho-Chehab/Address-some-issues-with-PM-runtime-at-media-subsystem/20210428-225742
git checkout b6dba4aea621c15b0aa6f92e548c74cd6994eb20
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=nds32
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
drivers/media/platform/exynos-gsc/gsc-core.c: In function 'gsc_remove':
>> drivers/media/platform/exynos-gsc/gsc-core.c:1220:35: error: 'dev' undeclared (first use in this function); did you mean 'pdev'?
1220 | if (!pm_runtime_status_suspended(dev))
| ^~~
| pdev
drivers/media/platform/exynos-gsc/gsc-core.c:1220:35: note: each undeclared identifier is reported only once for each function it appears in
vim +1220 drivers/media/platform/exynos-gsc/gsc-core.c
1207
1208 static int gsc_remove(struct platform_device *pdev)
1209 {
1210 struct gsc_dev *gsc = platform_get_drvdata(pdev);
1211 int i;
1212
1213 gsc_unregister_m2m_device(gsc);
1214 v4l2_device_unregister(&gsc->v4l2_dev);
1215
1216 vb2_dma_contig_clear_max_seg_size(&pdev->dev);
1217
1218 pm_runtime_disable(&pdev->dev);
1219
> 1220 if (!pm_runtime_status_suspended(dev))
1221 for (i = 0; i < gsc->num_clocks; i++)
1222 clk_disable_unprepare(gsc->clock[i]);
1223
1224 pm_runtime_set_suspended(dev);
1225
1226 dev_dbg(&pdev->dev, "%s driver unloaded\n", pdev->name);
1227 return 0;
1228 }
1229
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (37801 bytes)
Powered by blists - more mailing lists