linux-kernel - Re: [PATCH v2 3/4] tpm: Fix test for interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9ccf9df-2b0a-5bff-d38f-bad05cad9896@gmx.de>
Date:   Thu, 29 Apr 2021 00:13:23 +0200
From:   Lino Sanfilippo <LinoSanfilippo@....de>
To:     Stefan Berger <stefanb@...ux.ibm.com>, peterhuewe@....de,
        jarkko@...nel.org, jgg@...pe.ca
Cc:     stefanb@...ux.vnet.ibm.com, James.Bottomley@...senpartnership.com,
        keescook@...omium.org, jsnitsel@...hat.com, ml.linux@...oe.vision,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/4] tpm: Fix test for interrupts


Hi,

On 26.04.21 at 16:49, Stefan Berger wrote:

>> diff --git a/include/linux/tpm.h b/include/linux/tpm.h
>> index 55debe6..e9882acf 100644
>> --- a/include/linux/tpm.h
>> +++ b/include/linux/tpm.h
>> @@ -126,7 +126,7 @@ struct tpm_chip {
>>       struct tpm_chip_seqops bin_log_seqops;
>>       struct tpm_chip_seqops ascii_log_seqops;
>>   -    unsigned int flags;
>> +    unsigned long flags;
>
>
> This doesn't seem to be necessary.
>

The bitop makros require an unsigned long, leaving it as unsigned int results in
a compiler error:

error: passing argument 2 of ‘test_bit’ from incompatible pointer type [-Werror=incompatible-pointer-types]

> The rest looks good to me. I remember that last time I had tried to activate it some laptop didn't cooperate and we ended up reverting some code, but maybe your changes fixed all of that now. Though you may want to 'prepare for unforseen consequences' :-).
>

You may be right with your concerns and I will try to find some more hardware to test the patches.

Thanks for the review(s).

Regards,
Lino