linux-kernel - Re: [PATCH] Add blank line after declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YIkbtllJ65MF55wg@zn.tnic>
Date:   Wed, 28 Apr 2021 10:26:52 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Sanjana Srinidhi <sanjanasrinidhi1810@...il.com>
Cc:     mchehab@...nel.org, tony.luck@...el.com, james.morse@....com,
        rric@...nel.org, linux-edac@...r.kernel.org,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Add blank line after declarations

On Wed, Apr 28, 2021 at 01:44:12PM +0530, Sanjana Srinidhi wrote:
> Blank line is added after declarations to maintain code uniformity.
> 
> Signed-off-by: Sanjana Srinidhi <sanjanasrinidhi1810@...il.com>
> ---
>  drivers/edac/edac_mc.c | 3 +++
>  1 file changed, 3 insertions(+)

Before you send a patch, do:

git log -p -1 | ./scripts/get_maintainer.pl

that'll give you who to Cc. Then you'll see that there's no

edac@...r.kernel.org

mailing list but

linux-edac@...r.kernel.org

I've fixed up that now.

There's no

kernel@...r.kernel.org

either.

> diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
> index f6d462d0be2d..6b776bebd83f 100644
> --- a/drivers/edac/edac_mc.c
> +++ b/drivers/edac/edac_mc.c
> @@ -674,6 +674,7 @@ int edac_mc_add_mc_with_groups(struct mem_ctl_info *mci,
>  			       const struct attribute_group **groups)
>  {
>  	int ret = -EINVAL;
> +
>  	edac_dbg(0, "\n");
>  
>  #ifdef CONFIG_EDAC_DEBUG
> @@ -833,9 +834,11 @@ int edac_mc_find_csrow_by_page(struct mem_ctl_info *mci, unsigned long page)
>  
>  	for (i = 0; i < mci->nr_csrows; i++) {
>  		struct csrow_info *csrow = csrows[i];
> +
>  		n = 0;
>  		for (j = 0; j < csrow->nr_channels; j++) {
>  			struct dimm_info *dimm = csrow->channels[j]->dimm;
> +
>  			n += dimm->nr_pages;
>  		}
>  		if (n == 0)
> -- 

Please no, this is adding useless churn.

Such stylistic changes - if they would make sense at all - should be
done as part of other fixes - not as a standalone patch.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette