linux-kernel - Re: [PATCH 0/5] Cleanup and fixup for huge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4e851c9-9754-dd2a-c7a4-37bbefca704a@huawei.com>
Date:   Wed, 28 Apr 2021 16:32:06 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Anshuman Khandual <anshuman.khandual@....com>,
        <akpm@...ux-foundation.org>
CC:     <ziy@...dia.com>, <william.kucharski@...cle.com>,
        <willy@...radead.org>, <yang.shi@...ux.alibaba.com>,
        <aneesh.kumar@...ux.ibm.com>, <rcampbell@...dia.com>,
        <songliubraving@...com>, <kirill.shutemov@...ux.intel.com>,
        <riel@...riel.com>, <hannes@...xchg.org>, <minchan@...nel.org>,
        <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>
Subject: Re: [PATCH 0/5] Cleanup and fixup for huge_memory

On 2021/4/28 11:10, Anshuman Khandual wrote:
> 
> 
> On 4/27/21 7:02 PM, Miaohe Lin wrote:
>> Hi all,
>> This series contains cleanups to remove dedicated macro and remove
>> unnecessary tlb_remove_page_size() for huge zero pmd. Also this adds
>> missing read-only THP checking for transparent_hugepage_enabled() and
>> avoids discarding hugepage if other processes are mapping it. More
>> details can be found in the respective changelogs. Thanks!
>>
>> Miaohe Lin (5):
>>   mm/huge_memory.c: remove dedicated macro HPAGE_CACHE_INDEX_MASK
>>   mm/huge_memory.c: use page->deferred_list
>>   mm/huge_memory.c: add missing read-only THP checking in
>>     transparent_hugepage_enabled()
>>   mm/huge_memory.c: remove unnecessary tlb_remove_page_size() for huge
>>     zero pmd
>>   mm/huge_memory.c: don't discard hugepage if other processes are
>>     mapping it
> 
> I guess it might be just better to split the series into cleans-ups
> without functional change and then fixes separately.

Sounds reasonable. But IMO all of these changes are pretty simple and independent,
maybe it's ok to keep these together?

Many thanks for comment.

> .
>