linux-kernel - Re: [PATCH] ata: ahci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <24eb672c-9772-4e3f-e3de-0fe3390c659f@gmail.com>
Date:   Wed, 28 Apr 2021 11:40:44 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Timo Sigurdsson <public_timo.s@...entcreek.de>, axboe@...nel.dk,
        mripard@...nel.org, wens@...e.org, jernej.skrabec@...l.net,
        linux-ide@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Cc:     oliver@...inagl.nl, stable@...r.kernel.org
Subject: Re: [PATCH] ata: ahci_sunxi: Disable DIPM

Hello!

On 28.04.2021 2:05, Timo Sigurdsson wrote:

> DIPM is unsupported or broken on sunxi. Trying to enable the power
> management policy med_power_with_dipm on an Allwinner A20 SoC based board
> leads to immediate I/O errors and the attached SATA disk disappears from
> the /dev filesystem. A reset (power cycle) is required to make the SATA
> controller or disk work again. The A10 and A20 SoC data sheets and manuals
> don't mention DIPM at all [1], so it's fair to assume that it's simply not
> supported. But even if it were, it should be considered broken and best be
                             ^ was

> disabled in the ahci_sunxi driver.
> 
> Fixes: c5754b5220f0 ("ARM: sunxi: Add support for Allwinner SUNXi SoCs sata to ahci_platform")

    The "Fixes:" tag should immediately precede the signoff tag...

> [1] https://github.com/allwinner-zh/documents/tree/master/

    And this line should be immediately after the patch description.

> Signed-off-by: Timo Sigurdsson <public_timo.s@...entcreek.de>
> Tested-by: Timo Sigurdsson <public_timo.s@...entcreek.de>
[...]

MBR, Sergei