linux-kernel - Re: [PATCH 088/190] Revert "mmc_spi: add a status check for spi_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIkf2OFKCbIz8tiB@pendragon.ideasonboard.com>
Date:   Wed, 28 Apr 2021 11:42:00 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, Kangjie Lu <kjlu@....edu>,
        Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH 088/190] Revert "mmc_spi: add a status check for
 spi_sync_locked"

Hi Greg,

On Wed, Apr 28, 2021 at 09:18:18AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Apr 21, 2021 at 04:19:07PM +0300, Laurent Pinchart wrote:
> > On Wed, Apr 21, 2021 at 02:59:23PM +0200, Greg Kroah-Hartman wrote:
> > > This reverts commit 611025983b7976df0183390a63a2166411d177f1.
> > > 
> > > Commits from @umn.edu addresses have been found to be submitted in "bad
> > > faith" to try to test the kernel community's ability to review "known
> > > malicious" changes.  The result of these submissions can be found in a
> > > paper published at the 42nd IEEE Symposium on Security and Privacy
> > > entitled, "Open Source Insecurity: Stealthily Introducing
> > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > > of Minnesota) and Kangjie Lu (University of Minnesota).
> > > 
> > > Because of this, all submissions from this group must be reverted from
> > > the kernel tree and will need to be re-reviewed again to determine if
> > > they actually are a valid fix.  Until that work is complete, remove this
> > > change to ensure that no problems are being introduced into the
> > > codebase.
> > > 
> > > Cc: Kangjie Lu <kjlu@....edu>
> > > Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> > > Cc: Ulf Hansson <ulf.hansson@...aro.org>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > 
> > Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> 
> Thanks for the review!
> 
> > I don't spot an obvious issue with the original patch though.
> 
> Ulf did :)

I've replied separately, I still think it's not an issue :-)

-- 
Regards,

Laurent Pinchart