linux-kernel - [PATCH 1/2] tools/power/turbostat: Fix turbostat for AMD Zen CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3172c45b6e06627e19f3a6f71be7746d89ee8c2e.1619600637.git.yu.c.chen@intel.com>
Date:   Wed, 28 Apr 2021 17:09:03 +0800
From:   Chen Yu <yu.c.chen@...el.com>
To:     youling257 <youling257@...il.com>, Kurt Garloff <kurt@...loff.de>,
        Bingsong Si <owen.si@...oud.cn>,
        "Artem S . Tashkinov" <aros@....com>
Cc:     Terry Bowman <terry.bowman@....com>,
        Bas Nieuwenhuizen <bas@...nieuwenhuizen.nl>,
        Calvin Walton <calvin.walton@...stin.ca>,
        Borislav Petkov <bp@...e.de>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Chen Yu <yu.c.chen@...el.com>
Subject: [PATCH 1/2] tools/power/turbostat: Fix turbostat for AMD Zen CPUs

From: Bas Nieuwenhuizen <bas@...nieuwenhuizen.nl>

It was reported that on Zen+ system turbostat started exiting,
which was tracked down to the MSR_PKG_ENERGY_STAT read failing because
offset_to_idx wasn't returning a non-negative index.

This patch combined the modification from Bingsong Si and
Bas Nieuwenhuizen and addd the MSR to the index system as alternative for
MSR_PKG_ENERGY_STATUS.

Fixes: 9972d5d84d76 ("tools/power turbostat: Enable accumulate RAPL display")
Reported-by: youling257 <youling257@...il.com>
Tested-by: youling257 <youling257@...il.com>
Tested-by: Kurt Garloff <kurt@...loff.de>
Tested-by: Bingsong Si <owen.si@...oud.cn>
Tested-by: Artem S. Tashkinov <aros@....com>
Co-developed-by: Bingsong Si <owen.si@...oud.cn>
Co-developed-by: Terry Bowman <terry.bowman@....com>
Reviewed-by: Chen Yu <yu.c.chen@...el.com>
Signed-off-by: Bas Nieuwenhuizen <bas@...nieuwenhuizen.nl>
---
 tools/power/x86/turbostat/turbostat.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
index 5939615265f1..37759d6c463d 100644
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -297,7 +297,10 @@ int idx_to_offset(int idx)
 
 	switch (idx) {
 	case IDX_PKG_ENERGY:
-		offset = MSR_PKG_ENERGY_STATUS;
+		if (do_rapl & RAPL_AMD_F17H)
+			offset = MSR_PKG_ENERGY_STAT;
+		else
+			offset = MSR_PKG_ENERGY_STATUS;
 		break;
 	case IDX_DRAM_ENERGY:
 		offset = MSR_DRAM_ENERGY_STATUS;
@@ -326,6 +329,7 @@ int offset_to_idx(int offset)
 
 	switch (offset) {
 	case MSR_PKG_ENERGY_STATUS:
+	case MSR_PKG_ENERGY_STAT:
 		idx = IDX_PKG_ENERGY;
 		break;
 	case MSR_DRAM_ENERGY_STATUS:
@@ -353,7 +357,7 @@ int idx_valid(int idx)
 {
 	switch (idx) {
 	case IDX_PKG_ENERGY:
-		return do_rapl & RAPL_PKG;
+		return do_rapl & (RAPL_PKG | RAPL_AMD_F17H);
 	case IDX_DRAM_ENERGY:
 		return do_rapl & RAPL_DRAM;
 	case IDX_PP0_ENERGY:
-- 
2.25.1