linux-kernel - Re: [PATCH 1/1] lib: devres: Add error information printing for __devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210428143128.cafwzjzgwhb3akbe@skbuf>
Date:   Wed, 28 Apr 2021 14:31:28 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Zhen Lei <thunder.leizhen@...wei.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] lib: devres: Add error information printing for
 __devm_ioremap_resource()

On Wed, Apr 28, 2021 at 02:32:03PM +0800, Zhen Lei wrote:
> Ensure that all error handling branches print error information. In this
> way, when this function fails, the upper-layer functions can directly
> return an error code without missing debugging information. Otherwise,
> the error message will be printed redundantly or missing.
> 
> Fixes: 35bd8c07db2c ("devres: keep both device name and resource name in pretty name")
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
> ---

A Fixes: tag is probably a bit too drastic, but anyway:

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>