linux-kernel - Re: [PATCH 0/2] Add QCOM PMIC PWM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210428155422.GL1908499@yoga>
Date:   Wed, 28 Apr 2021 10:54:22 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Fenglin Wu <fenglinw@...eaurora.org>
Cc:     linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        subbaram@...eaurora.org, collinsd@...eaurora.org,
        aghayal@...eaurora.org
Subject: Re: [PATCH 0/2] Add QCOM PMIC PWM driver

On Tue 27 Apr 05:22 CDT 2021, Fenglin Wu wrote:

> Add PWM driver to support PWM modules inside QCOM PMIC chips which are accessed
> through SPMI bus. Normally, there would be multiple PWM modules with adjacent
> address spaces present in one PMIC chip, and each PWM module has 0x100 size of
> address space. With this driver, a pwm_chip with multiple pwm_device individuals
> is created, and each pwm_device individual is corresponding to one PWM module.
> 

Exposing this as individual pwm_chips will prevent us from enabling the
LED related use cases (patterns and multicolor) that most versions of
the hardware support.

I proposed [1] a while ago and think this is a better approach. I'll
take some time to respin this and send out the next version.

[1] https://lore.kernel.org/linux-arm-msm/20201021201224.3430546-1-bjorn.andersson@linaro.org/

Regards,
Bjorn

> Fenglin Wu (2):
>   dt-bindings: pwm: add bindings for PWM modules inside QCOM PMICs
>   pwm: pwm-qcom: add driver for PWM modules in QCOM PMICs
> 
>  .../devicetree/bindings/pwm/pwm-qcom.yaml          |  51 ++
>  drivers/pwm/Kconfig                                |   9 +
>  drivers/pwm/Makefile                               |   1 +
>  drivers/pwm/pwm-qcom.c                             | 585 +++++++++++++++++++++
>  4 files changed, 646 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/pwm-qcom.yaml
>  create mode 100644 drivers/pwm/pwm-qcom.c
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project.
>