linux-kernel - Re: [PATCH] media: siano: use DEFINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2b5365025e7a9162aae111b1c5134430a37e6ff8.camel@gmail.com>
Date:   Wed, 28 Apr 2021 21:14:34 +0500
From:   Muhammad Usama Anjum <musamaanjum@...il.com>
To:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        "open list:SIANO DVB DRIVER" <linux-media@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        zhengyongjun3@...wei.com, kernel-janitors@...r.kernel.org,
        colin.king@...onical.com, dan.carpenter@...cle.com
Cc:     musamaanjum@...il.com
Subject: Re: [PATCH] media: siano: use DEFINE_MUTEX() for mutex lock

Reminder!

On Tue, 2021-04-06 at 01:52 +0500, Muhammad Usama Anjum wrote:
> mutex lock can be initialized with DEFINE_MUTEX() rather than
> explicitly calling mutex_init().
> 
> Signed-off-by: Muhammad Usama Anjum <musamaanjum@...il.com>
> ---
>  drivers/media/common/siano/smscoreapi.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/media/common/siano/smscoreapi.c b/drivers/media/common/siano/smscoreapi.c
> index 410cc3ac6f94..7f5b638d2458 100644
> --- a/drivers/media/common/siano/smscoreapi.c
> +++ b/drivers/media/common/siano/smscoreapi.c
> @@ -414,10 +414,10 @@ struct smscore_registry_entry_t {
>  
>  static struct list_head g_smscore_notifyees;
>  static struct list_head g_smscore_devices;
> -static struct mutex g_smscore_deviceslock;
> +static DEFINE_MUTEX(g_smscore_deviceslock);
>  
>  static struct list_head g_smscore_registry;
> -static struct mutex g_smscore_registrylock;
> +static DEFINE_MUTEX(g_smscore_registrylock);
>  
>  static int default_mode = DEVICE_MODE_NONE;
>  
> @@ -2123,10 +2123,7 @@ static int __init smscore_module_init(void)
>  {
>  	INIT_LIST_HEAD(&g_smscore_notifyees);
>  	INIT_LIST_HEAD(&g_smscore_devices);
> -	mutex_init(&g_smscore_deviceslock);
> -
>  	INIT_LIST_HEAD(&g_smscore_registry);
> -	mutex_init(&g_smscore_registrylock);
>  
>  	return 0;
>  }