linux-kernel - Re: [PATCH v6 1/3] dt-bindings:iio:adc: add generic settling-time-us and oversampling-ratio channel properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210428175931.00002a7e@Huawei.com>
Date:   Wed, 28 Apr 2021 17:59:31 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
CC:     Rob Herring <robh+dt@...nel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "Pengutronix Kernel Team" <kernel@...gutronix.de>,
        David Jander <david@...tonic.nl>,
        "Robin van der Gracht" <robin@...tonic.nl>,
        <linux-iio@...r.kernel.org>,
        "Lars-Peter Clausen" <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        "Dmitry Torokhov" <dmitry.torokhov@...il.com>
Subject: Re: [PATCH v6 1/3] dt-bindings:iio:adc: add generic
 settling-time-us and oversampling-ratio channel properties

On Wed, 28 Apr 2021 09:32:06 +0200
Oleksij Rempel <o.rempel@...gutronix.de> wrote:

> Settling time and over sampling is a typical challenge for different IIO ADC
> devices. So, introduce channel specific settling-time-us and oversampling-ratio
> properties to cover this use case.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
This and patch 2 both look good to me.  Given Rob gave a minor comment on the
previous version I don't feel I need him to look at this again.

Will pick up in a few days if no other reviews come in to require a v7.

Thanks,

Jonathan

> ---
>  Documentation/devicetree/bindings/iio/adc/adc.yaml | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> index 912a7635edc4..db348fcbb52c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml
> @@ -39,4 +39,16 @@ properties:
>        The first value specifies the positive input pin, the second
>        specifies the negative input pin.
>  
> +  settling-time-us:
> +    description:
> +      Time between enabling the channel and first stable readings.
> +
> +  oversampling-ratio:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Oversampling is used as replacement of or addition to the low-pass filter.
> +      In some cases, the desired filtering characteristics are a function the
> +      device design and can interact with other characteristics such as
> +      settling time.
> +
>  additionalProperties: true