linux-kernel - Re: [PATCH] proc: Use seq_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wibrw+PnBiQbkGy+5p4GpkPwmmodw-beODikL-tiz0dFQ@mail.gmail.com>
Date:   Wed, 28 Apr 2021 10:46:35 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Christoph Hellwig <hch@....de>
Cc:     Arusekk <arek_koz@...pl>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Alexey Dobriyan <adobriyan@...il.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] proc: Use seq_read_iter where possible

On Wed, Apr 28, 2021 at 6:03 AM Christoph Hellwig <hch@....de> wrote:
>
> Unless Linus changed his mind just patching the file you care about for
> now seems like the best idea.

I'm ok with expanding splice() use, but I do want it to be on a
case-by-case basis and with comments about what actually used splice()
in the odd circumstances.

Our splice infrastructure is probably a lot safer than it used to be
now that set_fs() is gone, but splice() on odd files does remain
historically a source of not just bugs, but bugs that were security
issues.

So it's mainly a "once bitten, twice shy" thing for me, which is why
I'm more than happy to extend splice(), but want to do so in a very
careful and controlled - and documented - manner, rather than the old
situation where "pretty much everything can do splice, whether it
actually works or not".

                 Linus