linux-kernel - Re: [PATCH] arch/s390/configs: Change CONFIG_VIRTIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e6a8f49-4af7-1411-0aa8-a40641812d37@de.ibm.com>
Date:   Thu, 29 Apr 2021 08:47:26 +0200
From:   Christian Borntraeger <borntraeger@...ibm.com>
To:     Thomas Huth <thuth@...hat.com>, linux-s390@...r.kernel.org,
        Heiko Carstens <hca@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, Vasily Gorbik <gor@...ux.ibm.com>,
        Marc Hartmayer <mhartmay@...ux.ibm.com>,
        Halil Pasic <pasic@...ux.ibm.com>, cohuck@...hat.com
Subject: Re: [PATCH] arch/s390/configs: Change CONFIG_VIRTIO_CONSOLE to "m"

On 28.04.21 10:24, Thomas Huth wrote:
> In former times, the virtio-console code had to be compiled into
> the kernel since the old guest virtio transport had some hard de-
> pendencies. But since the old virtio transport has been removed in
> commit 7fb2b2d51244 ("s390/virtio: remove the old KVM virtio transport"),
> we do not have this limitation anymore.
> Commit bb533ec8bacd ("s390/config: do not select VIRTIO_CONSOLE via
> Kconfig") then also lifted the hard setting in the Kconfig system, so
> we can finally switch the CONFIG_VIRTIO_CONSOLE knob to compile this
> driver as a module now, making it more flexible for the user to only
> load it if it is really required.
> 
> Signed-off-by: Thomas Huth <thuth@...hat.com>

applied, thanks.
> ---
>   arch/s390/configs/debug_defconfig | 2 +-
>   arch/s390/configs/defconfig       | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/s390/configs/debug_defconfig b/arch/s390/configs/debug_defconfig
> index dc0b69058ac4..04ce0edd0b31 100644
> --- a/arch/s390/configs/debug_defconfig
> +++ b/arch/s390/configs/debug_defconfig
> @@ -548,7 +548,7 @@ CONFIG_INPUT_EVDEV=y
>   # CONFIG_INPUT_MOUSE is not set
>   # CONFIG_SERIO is not set
>   CONFIG_LEGACY_PTY_COUNT=0
> -CONFIG_VIRTIO_CONSOLE=y
> +CONFIG_VIRTIO_CONSOLE=m
>   CONFIG_HW_RANDOM_VIRTIO=m
>   CONFIG_RAW_DRIVER=m
>   CONFIG_HANGCHECK_TIMER=m
> diff --git a/arch/s390/configs/defconfig b/arch/s390/configs/defconfig
> index 320379da96d9..e448711eff8d 100644
> --- a/arch/s390/configs/defconfig
> +++ b/arch/s390/configs/defconfig
> @@ -540,7 +540,7 @@ CONFIG_INPUT_EVDEV=y
>   # CONFIG_INPUT_MOUSE is not set
>   # CONFIG_SERIO is not set
>   CONFIG_LEGACY_PTY_COUNT=0
> -CONFIG_VIRTIO_CONSOLE=y
> +CONFIG_VIRTIO_CONSOLE=m
>   CONFIG_HW_RANDOM_VIRTIO=m
>   CONFIG_RAW_DRIVER=m
>   CONFIG_HANGCHECK_TIMER=m
>