linux-kernel - Re: [PATCH v9] USB: serial: cp210x: Add support for GPIOs on CP2108

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YIpYVk0bwIXFyAuE@hovoldconsulting.com>
Date:   Thu, 29 Apr 2021 08:55:18 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Tung Pham <Tung.Pham@...abs.com>
Cc:     Pho Tran <photranvan0712@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Hung Nguyen <Hung.Nguyen@...abs.com>,
        Pho Tran <Pho.Tran@...abs.com>
Subject: Re: [PATCH v9] USB: serial: cp210x: Add support for GPIOs on CP2108

On Thu, Apr 29, 2021 at 02:54:09AM +0000, Tung Pham wrote:

> So my questions again are:
> 
>  1) Have you verified that the struct cp210x_quad_port_config above
>     actually matches what the device uses?
> 
>  2) Do you have any documentation of the structures as expected by the
>     device firmware (not your library)?
> 
> 
> Tung Pham: the device return some unused bytes, and manufacturing
> library already discard these byte to assign value to PORT_CONFIG, so
> you don't see padding byte on PORT_CONFIG structure.   you can find
> the structure  of port setting in this code: 
> 
> https://www.silabs.com/documents/public/software/USBXpressHostSDK-Linux.tar
> 
> 
> \USBXpressHostSDK-Linux\USBXpressHostSDK\CP210x\srcpkg\cp210xmanufacturing_1.0.tar\cp210xmanufacturing_1.0\cp210xmanufacturing\cp210xmanufacturing\src\CP2104Device.cpp
> 
> CP210x_STATUS CCP2104Device::GetPortConfig(PORT_CONFIG* PortConfig)

Thanks for confirming.

Johan