linux-kernel - Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YIpaqTHV/zYHrV1z@unreal>
Date:   Thu, 29 Apr 2021 10:05:13 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Valdis Klētnieks <valdis.kletnieks@...edu>
Cc:     bkkarthik <bkkarthik@...u.pes.edu>,
        Anupama K Patil <anupamakpatil123@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        skhan@...uxfoundation.org, gregkh@...uxfoundation.org,
        kernelnewbies@...nelnewbies.org
Subject: Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching
 devices

On Thu, Apr 29, 2021 at 12:31:13AM -0400, Valdis Klētnieks wrote:
> On Tue, 27 Apr 2021 07:26:27 +0300, Leon Romanovsky said:
> > On Mon, Apr 26, 2021 at 11:20:32PM +0530, bkkarthik wrote:
> > > These were only intended for a clean-up job, the idea of this function came from how PCI handles procfs.
> > > Maybe those should be changed?
> >
> > Probably, the CONFIG_PROC_FS around pci_proc_*() is not needed too.
> 
> Will that actually build correctly if it's an embedded system or something build with
> CONFIG_PROC_FS=n?  I'd expect that to die a horrid death while linking vmlinx due
> to stuff inside that #ifdef calling symbols only present with PROC_FS=m/y.

We are talking about pci_proc_detach_device() and pci_proc_detach_bus() here.
They will build perfectly without CONFIG_PROC_FS.

Thanks