linux-kernel - Re: [PATCH bpf-next] libbpf: Fix signed overflow in ringbuf_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+i-1C3YJQt60FBaOg3pHD+BG6kuUK1Z8RiZ87O9+WSr1Ynbyg@mail.gmail.com>
Date:   Thu, 29 Apr 2021 10:46:06 +0200
From:   Brendan Jackman <jackmanb@...gle.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     KP Singh <kpsingh@...nel.org>, bpf <bpf@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf-next] libbpf: Fix signed overflow in ringbuf_process_ring

On Wed, 28 Apr 2021 at 20:13, Andrii Nakryiko <andrii.nakryiko@...il.com> wrote:
...
>
> Yep, let's cap. But to not penalize a hot loop with extra checks.
> Let's use int64_t internally for counting and only cap it before the
> return.

Cool, sounds good. Patch incoming but I'm on interrupts duty this week
so might not be today/tomorrow.