linux-kernel - Re: [PATCH v2] samples/landlock: fix path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20b46fb2-94e2-989a-9102-5e5c7be3b8ba@digikod.net>
Date:   Thu, 29 Apr 2021 11:22:06 +0200
From:   Mickaël Salaün <mic@...ikod.net>
To:     trix@...hat.com, nathan@...nel.org, ndesaulniers@...gle.com
Cc:     linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com,
        James Morris <jmorris@...ei.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH v2] samples/landlock: fix path_list memory leak


On 28/04/2021 23:38, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> Clang static analysis reports this error
> 
> sandboxer.c:134:8: warning: Potential leak of memory
>   pointed to by 'path_list'
>         ret = 0;
>               ^
> path_list is allocated in parse_path() but never freed.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Reviewed-by: Mickaël Salaün <mic@...ux.microsoft.com>

Previous version:
https://lore.kernel.org/r/20210427183755.2790654-1-trix@redhat.com

> ---
> v2:
>   - Remove NULL ptr check
> ---
>  samples/landlock/sandboxer.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/samples/landlock/sandboxer.c b/samples/landlock/sandboxer.c
> index 7a15910d2171..8859fc193542 100644
> --- a/samples/landlock/sandboxer.c
> +++ b/samples/landlock/sandboxer.c
> @@ -134,6 +134,7 @@ static int populate_ruleset(
>  	ret = 0;
>  
>  out_free_name:
> +	free(path_list);
>  	free(env_path_name);
>  	return ret;
>  }
>