linux-kernel - Re: [PATCH] Fix indentation of block comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YIp8UnL4big41DdL@hovoldconsulting.com>
Date:   Thu, 29 Apr 2021 11:28:50 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Sanjana Srinidhi <sanjanasrinidhi1810@...il.com>
Cc:     linux@...inikbrodowski.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix indentation of block comments

On Thu, Apr 29, 2021 at 02:25:32PM +0530, Sanjana Srinidhi wrote:
> Trailing */ of block comments is moved to a new line to maintain code uniformity.
> 
> Signed-off-by: Sanjana Srinidhi <sanjanasrinidhi1810@...il.com>
> ---
>  drivers/pcmcia/soc_common.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pcmcia/soc_common.c b/drivers/pcmcia/soc_common.c
> index 98b6d96a4435..7a88bd9bd4ed 100644
> --- a/drivers/pcmcia/soc_common.c
> +++ b/drivers/pcmcia/soc_common.c
> @@ -28,7 +28,8 @@
>      the provisions above, a recipient may use your version of this
>      file under either the MPL or the GPL.
>  
> -======================================================================*/
> +======================================================================
> +*/

These kind of "cleanups" are mostly pointless and amount to nothing more
than noise.

Please consider working in drivers/staging/ which currently works as
some sort of learning-ground for new contributors instead if you really
want to send these kind of patches.

Johan