linux-kernel - Re: [PATCH v1 4/6] staging: media: atomisp: reformat code comment blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Apr 2021 15:54:56 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Deepak R Varma <drv@...lo.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, mh12gx2825@...il.com
Subject: Re: [PATCH v1 4/6] staging: media: atomisp: reformat code comment
 blocks

On Thu, Apr 29, 2021 at 05:25:30PM +0530, Deepak R Varma wrote:
> On Thu, Apr 29, 2021 at 02:43:04PM +0300, Dan Carpenter wrote:
> > On Thu, Apr 29, 2021 at 05:01:41PM +0530, Deepak R Varma wrote:
> > > On Thu, Apr 29, 2021 at 01:08:09PM +0300, Dan Carpenter wrote:
> > > > On Wed, Apr 21, 2021 at 10:26:09PM +0530, Deepak R Varma wrote:
> > > > > @@ -1044,7 +1048,7 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd,
> > > > >  	}
> > > > >  
> > > > >  	/*
> > > > > -	// set analog/digital gain
> > > > > +	 * set analog/digital gain
> > > > >  	switch(AnalogGain)
> > > > >  	{
> > > > >  	case 0:
> > > > 
> > > > How on earth does this compile?
> > > 
> > > There is a closing */ down under after the entire switch block. The
> > > change I made is within the comment block. I have compiled the built the
> > > driver successfully.
> > 
> > Oh...  Duh.  I thought you converted the // to /*.  This patch doesn't
> > make any sense though because originally it was commented out code, but
> > now it's a commented out ball of code and notes.
> 
> No problem. It looks wrong with the limited lines in diff. Appreciate
> you looking at it though.
> 

Yeah.  That's fine by me.

> Is it okay if I send in a separate patch with comment clean up? There
> are several #if 0 code block directives for this driver that I believe can
> be taken off as well. Should I clean those up as well?

Yep.  Delete those as well.

regards,
dan carpenter