linux-kernel - Re: [PATCH v6,2/4] PKCS#7: Check codeSigning EKU for kernel module and kexec pe verification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Apr 2021 21:04:41 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Lee, Chun-Yi" <joeyli.kernel@...il.com>,
        David Howells <dhowells@...hat.com>
Cc:     kbuild-all@...ts.01.org, Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        Ben Boeckel <me@...boeckel.net>,
        Randy Dunlap <rdunlap@...radead.org>,
        Malte Gell <malte.gell@....de>,
        Varad Gautam <varad.gautam@...e.com>, keyrings@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6,2/4] PKCS#7: Check codeSigning EKU for kernel module
 and kexec pe verification

Hi Chun-Yi",

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on next-20210429]
[cannot apply to cryptodev/master crypto/master v5.12]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Lee-Chun-Yi/Check-codeSigning-extended-key-usage-extension/20210429-153115
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d72cd4ad4174cfd2257c426ad51e4f53bcfde9c9
config: powerpc64-randconfig-m031-20210429 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/63e6809a57ca114d297694a24283256990aa10df
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Lee-Chun-Yi/Check-codeSigning-extended-key-usage-extension/20210429-153115
        git checkout 63e6809a57ca114d297694a24283256990aa10df
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   certs/blacklist.c: In function 'is_key_on_revocation_list':
>> certs/blacklist.c:188:8: error: too few arguments to function 'pkcs7_validate_trust'
     188 |  ret = pkcs7_validate_trust(pkcs7, blacklist_keyring);
         |        ^~~~~~~~~~~~~~~~~~~~
   In file included from certs/blacklist.h:3,
                    from certs/blacklist.c:19:
   include/crypto/pkcs7.h:32:12: note: declared here
      32 | extern int pkcs7_validate_trust(struct pkcs7_message *pkcs7,
         |            ^~~~~~~~~~~~~~~~~~~~


vim +/pkcs7_validate_trust +188 certs/blacklist.c

56c5812623f953 Eric Snowberg 2021-01-22  179  
56c5812623f953 Eric Snowberg 2021-01-22  180  /**
56c5812623f953 Eric Snowberg 2021-01-22  181   * is_key_on_revocation_list - Determine if the key for a PKCS#7 message is revoked
56c5812623f953 Eric Snowberg 2021-01-22  182   * @pkcs7: The PKCS#7 message to check
56c5812623f953 Eric Snowberg 2021-01-22  183   */
56c5812623f953 Eric Snowberg 2021-01-22  184  int is_key_on_revocation_list(struct pkcs7_message *pkcs7)
56c5812623f953 Eric Snowberg 2021-01-22  185  {
56c5812623f953 Eric Snowberg 2021-01-22  186  	int ret;
56c5812623f953 Eric Snowberg 2021-01-22  187  
56c5812623f953 Eric Snowberg 2021-01-22 @188  	ret = pkcs7_validate_trust(pkcs7, blacklist_keyring);
56c5812623f953 Eric Snowberg 2021-01-22  189  
56c5812623f953 Eric Snowberg 2021-01-22  190  	if (ret == 0)
56c5812623f953 Eric Snowberg 2021-01-22  191  		return -EKEYREJECTED;
56c5812623f953 Eric Snowberg 2021-01-22  192  
56c5812623f953 Eric Snowberg 2021-01-22  193  	return -ENOKEY;
56c5812623f953 Eric Snowberg 2021-01-22  194  }
56c5812623f953 Eric Snowberg 2021-01-22  195  #endif
56c5812623f953 Eric Snowberg 2021-01-22  196  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (33418 bytes)