linux-kernel - Re: [PATCH 13/16] soc: imx: gpcv2: correct pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08d8573e7395b341cdec55ee4f92d8cd3da7d0d3.camel@pengutronix.de>
Date:   Thu, 29 Apr 2021 16:25:56 +0200
From:   Lucas Stach <l.stach@...gutronix.de>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>, robh+dt@...nel.org,
        shawnguo@...nel.org, s.hauer@...gutronix.de
Cc:     kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
        p.zabel@...gutronix.de, krzk@...nel.org, agx@...xcpu.org,
        marex@...x.de, andrew.smirnov@...il.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, ping.bai@....com,
        frieder.schrempf@...tron.de, aford173@...il.com, abel.vesa@....com,
        Peng Fan <peng.fan@....com>
Subject: Re: [PATCH 13/16] soc: imx: gpcv2: correct pm_runtime_get_sync usage

Am Donnerstag, dem 29.04.2021 um 15:30 +0800 schrieb Peng Fan (OSS):
> From: Peng Fan <peng.fan@....com>
> 
> When the return value is negative, there is error, otherwise it is
> expected.

Good catch! As the runtime pm handling is added in this series, this
should be squashed into patch 06/16 to not add broken code and then fix
it in the same series. Change looks good to me.

> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  drivers/soc/imx/gpcv2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
> index 42b9be05e1f2..d2ce47a5ebad 100644
> --- a/drivers/soc/imx/gpcv2.c
> +++ b/drivers/soc/imx/gpcv2.c
> @@ -197,7 +197,7 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd)
>  	int ret;
>  
> 
> 
> 
>  	ret = pm_runtime_get_sync(domain->dev);
> -	if (ret) {
> +	if (ret < 0) {
>  		pm_runtime_put_noidle(domain->dev);
>  		return ret;
>  	}